Skip to content

Add try-catch around window.sessionStorage access #1977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Add try-catch around window.sessionStorage access #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# Unreleased changes

* [#1977](https://github.com/mozilla/glean.js/pull/1977): Add try-catch around window.sessionStorage access to prevent uncaught error upon `import`.

[Full changelog](https://github.com/mozilla/glean.js/compare/v5.0.3...main)

# v5.0.3 (2024-08-02)
Expand Down
17 changes: 13 additions & 4 deletions glean/src/core/glean.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,10 +533,19 @@ declare global {
}

// Only set `Glean` values whenever running inside of a browser.
if (
typeof window !== "undefined" &&
typeof window.sessionStorage !== "undefined"
) {
// When cookies/localStorage/sessionStorage are disabled (at least in Firefox
// and Chrome), an access attempt on the window.sessionStorage property will
// throw an error ("The operation is insecure." in Firefox).
// So try-catch is needed here.
let hasStorage = false;
try {
hasStorage = typeof window !== "undefined" &&
typeof window.sessionStorage !== "undefined";
} catch (e) {
console.error("No session storage available", e);
}

if (hasStorage) {
window.Glean = {
setLogPings: (flag: boolean) => {
setDebugOptionInSessionStorage(DebugOption.LogPings, flag);
Expand Down