Skip to content

Conversation

@badboy
Copy link
Member

@badboy badboy commented Mar 19, 2024

Not sure how to best that other than manual, which I've done in the sample app.
We remove the glean_timestamp from testGetValue so consumers don't need to check for it.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from Dexterp37 March 19, 2024 11:39
@badboy badboy requested review from rosahbruno and removed request for Dexterp37 March 19, 2024 11:40
Copy link
Contributor

@rosahbruno rosahbruno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks great, thanks!

@rosahbruno rosahbruno merged commit 4dfb8b6 into main Mar 20, 2024
@badboy badboy deleted the default-event-timestamp branch March 20, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants