Bug 1868748 - truncate event extra strings to 500 bytes #1849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosahbruno
force-pushed
the
1868748-trim-event-extras-to-500-bytes
branch
2 times, most recently
from
58702b2 to
0c3e37b
Compare
travis79
reviewed
Dec 13, 2023
rosahbruno
force-pushed
the
1868748-trim-event-extras-to-500-bytes
branch
from
e4b2e7a to
4cafdcd
Compare
travis79
approved these changes
Dec 21, 2023
Member
travis79
left a comment
travis79
left a comment
There was a problem hiding this comment.
This is looking really good. I especially like the more descriptive naming of the constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need onemozilla/gleanrepository