Skip to content

Conversation

@rosahbruno
Copy link
Contributor

To properly configure Glean.js to be only synchronous, we are going to drop the existing support for node first. The other PR I am working on #1808 is rebuilding the Glean internals. To be able to do this, we first need to remove QT, node, and the webext implementations.

By removing these first, we are going to be able to build new platforms/packages for each in a more reusable way that scales nicer than what we are currently doing.

The reason we are doing this now and then going to put it back in is because to be able to drop the async/sync/shared file structure, we need to remove all the platforms except for web.

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work

@auto-assign auto-assign bot requested a review from Dexterp37 November 10, 2023 07:17
Copy link
Contributor

@Dexterp37 Dexterp37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with moving forward with this, as discussed during our workweek.

We should make sure that this has no impact on the one consumer we have (Treeherder). @badboy checked and it seems this is just UI.

We should probably merge this, cut a new alpha release and see.

@rosahbruno rosahbruno merged commit 31c7f2c into mozilla:main Nov 13, 2023
@rosahbruno rosahbruno deleted the remove-node branch November 13, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants