Bug 1701578 - Remove a circular dependency in the upload module #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
commented
Apr 6, 2021
brizental
reviewed
Apr 7, 2021
... instead of using the Glean singleton. This removes at least one circular dependency.
This additionally fixes the other tests.
Dexterp37
force-pushed
the
upload_circular_deps
branch
from
f9385db to
6d7806b
Compare
Dexterp37
changed the title
brizental
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes one more circular dependency, but it's quite a bit of work. We're now at 19!
I've got a few more PRs lined up.