Bug 1701578 (Part 1) - Remove some circular dependencies #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by breaking the `Metrics` interface out of the metrics index file. A similar approach was taken for the ping payload.
brizental
approved these changes
Apr 1, 2021
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
|
||
| import { Metrics } from "../metrics/metrics_interface.js"; |
Contributor
There was a problem hiding this comment.
I've seen multiple projects that have a types/ folder with all the types. Not for this PR, but I wonder if we could benefit form that. WDYT?
Contributor
Author
There was a problem hiding this comment.
Yeah, it might make sense :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings down the circular dependencies detected by
npm run lint:circular-depsfrom 34 to 20.These are the low hanging fruits. I'll follow up with other work next.