Bug 1716951 - Implement the Custom Distribution Metric #1516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosahbruno
added a commit
to rosahbruno/glean.js
that referenced
this pull request
Sep 22, 2022
rosahbruno
changed the title
Changes - port over custom distribution metric - port over custom distribution metrics tests - add construct method to histogram types
For some reason when trying to convert the enum values of "Linear" and "Exponential" with the first letters capitalized, it was throwing errors. When the enum values are lowercase, the tests and glean_parser seem to have an easier time reading those values.
rosahbruno
force-pushed
the
1716951-custom-distribution-metric
branch
from
f42b5fb to
e12ae3f
Compare
By setting the param as HistogramType, we can avoid casting the returned object from the function as a Histogram. The string we are casting to be a HistogramType already has validation that ensures it is one of the values of the enum.
Dexterp37
requested changes
Oct 7, 2022
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
only a few nits! Good job.
glean/tests/unit/core/metrics/custom_distribution_exponential.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_exponential.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_exponential.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_exponential.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_linear.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_linear.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_linear.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_linear.spec.ts
Outdated
Show resolved
Hide resolved
glean/tests/unit/core/metrics/custom_distribution_linear.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@Dexterp37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Custom Distribution metric.
The documentation for the Glean book is updated in this PR - mozilla/glean#2205
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need onemozilla/gleanrepository