Bug 1679380 - Implement the counter metric type #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dexterp37
requested changes
Dec 16, 2020
| const transformFn = ((amount) => { | ||
| return (v?: CounterMetricPayload): CounterMetricPayload => { | ||
| let result = v ? v + amount : amount; | ||
| if (result > Number.MAX_SAFE_INTEGER) { |
Contributor
There was a problem hiding this comment.
Does this change the maximum representable number compared to the SDK?
Contributor
Author
There was a problem hiding this comment.
Good question, let me check... Actually is much larger then the maximum representable number on the SDK:
- Javascript: 9007199254740991
- Rust: 4294967295
I was letting errors pass because they were only warning and I didn't see them. This is easier than overwriting every recommended rule that is a warning into an error.
Dexterp37
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit (008bce4) is a bonus. I am not sure that is a good pattern, but it does centralize payload validation instead of doing it in a bunch of different places and in different ways, and I think that at least is good. Please let me know what you think :)