Bug 1690253 - Implement the 'events' ping #1267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..And more coreMetrics as well because it makes sense.
brizental
commented
Mar 16, 2022
Comment on lines
+45
to
+48
| startup: | | ||
| The ping was submitted at startup. | ||
| The events ping is always sent if there are any pending events at startup, | ||
| because event timestamps are not as reliable across application runs. |
Contributor
Author
There was a problem hiding this comment.
We did not discuss in the bug, but I thought it made sense to also include the startup trigger for sending the events ping as well as the max_capacity.
brizental
commented
Mar 16, 2022
| The events ping is always sent if there are any pending events at startup, | ||
| because event timestamps are not as reliable across application runs. | ||
| max_capacity: | | ||
| The maximum number of events was reached (default 500 events). |
Contributor
Author
There was a problem hiding this comment.
Different from the other SDKs, max capacity will only apply for the 'events' ping as discussed in this proposal.
badboy
reviewed
Mar 17, 2022
badboy
approved these changes
Mar 17, 2022
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need one