1699674 - Fix support for ES6 importing #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 19, 2021 14:54
This is a very weird change, I know, but there is good reason behind it: 1. ESM resolution algorithm does not currently support automatic resolution of file extensions and does not have the hability to import directories that have an index file. The extension and the name of the file being import need to _always_ be spcified. See: https://nodejs.org/api/esm.html#esm_customizing_esm_specifier_resolution_algorithm 2. Typescript does not provide features that change compiled JS code. This means there is no Typescript feature to include the ".js" on compiled code. See: microsoft/TypeScript#16577 (comment) All of this results in this weird change. It is the accepted workaround for this issue and until ES6 imports support automatic resolution of extensions, we will keep it.
Dexterp37
approved these changes
Mar 19, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
Thanks for the great work.
Dexterp37
reviewed
Mar 19, 2021
Dexterp37
requested changes
Mar 22, 2021
Contributor
Dexterp37
left a comment
Dexterp37
left a comment
There was a problem hiding this comment.
Let's add a changelog entry :)
Co-authored-by: Alessio Placitelli <alessio.placitelli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.