Bug 1710828 - Record error in case value of incorrect type is given to metric recording function #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
changed the title
brizental
force-pushed
the
1710828-metric-creation-error-0
branch
from
9e01711 to
f4192d2
Compare
badboy
approved these changes
Mar 10, 2022
Co-authored-by: Jan-Erik Rediger <badboy@archlinux.us>
brizental
force-pushed
the
1710828-metric-creation-error-0
branch
from
44d0ad0 to
f8c81e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is missing event metric type, which I'll send in a separate PR, because that one required a bit more complex changes and the changes were self contained (#1218)
Note: this PR is long, but it was not possible to make it smaller than it currently is. I suggest reviewing commit by commit because I tried to be extra mindful of containing related changes per commit.
Pull Request checklist
glean/folder, run:npm run testRuns all testsnpm run lintRuns all lintersCHANGELOG.mdor an explanation of why it does not need one