Skip to content

Bug 1742613 - Remove deprecated headers from Glean pings #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Bug 1742613 - Remove deprecated headers from Glean pings #1046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db3568b
Remove deprecated headers from Glean pings
brizental Dec 20, 2021
2aae42a
Update CHANGELOG.md
brizental Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
new behaviour only deletes the actually invalid data and leave the rest of the ping intact.
* [#1065](https://github.com/mozilla/glean.js/pull/1065): Only import metric types into the library when they are used either by the user or Glean itself.
* Previously the code required to deserialize metric data from the database was always imported by the library even if the metric type was never used by the client. This effort will decrease the size of the Glean.js bundles that don't import all the metric types.
* [#1046](https://github.com/mozilla/glean.js/pull/1046): Remove legacy X-Client-Type X-Client-Version from Glean pings.

# v0.30.0 (2022-01-10)

[Full changelog](https://github.com/mozilla/glean.js/compare/v0.29.0...v0.30.0)
Expand Down
2 changes: 0 additions & 2 deletions glean/src/core/upload/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ class PingUploadWorker {
...ping.headers,
"Content-Type": "application/json; charset=utf-8",
"Date": (new Date()).toISOString(),
"X-Client-Type": "Glean.js",
"X-Client-Version": GLEAN_VERSION,
"X-Telemetry-Agent": `Glean/${GLEAN_VERSION} (JS on ${await Context.platform.info.os()})`
};

Expand Down
2 changes: 0 additions & 2 deletions glean/tests/unit/core/upload/worker.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,6 @@ describe("PingUploadWorker", function() {
assert.ok("Date" in headers);
assert.ok("Content-Length" in headers);
assert.ok("Content-Type" in headers);
assert.ok("X-Client-Type" in headers);
assert.ok("X-Client-Version" in headers);
assert.ok("X-Telemetry-Agent" in headers);
assert.strictEqual(headers["Content-Encoding"], "gzip");
});
Expand Down