Skip to content

Conversation

@brizental
Copy link
Contributor

@brizental brizental commented Dec 7, 2021

Pull Request checklist

  • Quality: Make sure this PR builds and runs cleanly.
    • Inside the glean/ folder, run:
      • npm run test Runs all tests
      • npm run lint Runs all linters
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry to CHANGELOG.md or an explanation of why it does not need one
  • Documentation: This PR includes documentation changes, an explanation of why it does not need that or a follow-up bug has been filed to do that work
    • Docstring has been updated. Don't think there are any other places to update.

@auto-assign auto-assign bot requested a review from badboy December 7, 2021 14:04
@brizental brizental force-pushed the 1742450-no-op-shutdown branch from bd6e690 to e238479 Compare December 7, 2021 14:22
@brizental brizental force-pushed the 1742450-no-op-shutdown branch from e238479 to 2b918fc Compare December 7, 2021 14:40
@brizental brizental merged commit 4260b2b into mozilla:main Dec 7, 2021
@brizental brizental deleted the 1742450-no-op-shutdown branch December 7, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants