Skip to content

Conversation

@nshirley
Copy link
Contributor

@nshirley nshirley commented Sep 30, 2025

Because:

  • We have a step that will wait for an email up to 45 seconds

This Commit:

  • Runs the email code fetch in parallel with another request to use whichever we get back first, speeding up tests

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Here, these specific tests in Nightly took > 1m to run
image


And on this branch ~20s for the same tests
image


Also, I added a console.error to capture if verifyIfNeeded catches an error. It shows up in the trace like this so we'll get more visibility into tests should this cause issues.
image

Other information (Optional)

Any other information that is important to this pull request.

Because:
 - We have a step that will wait for an email up to 45 seconds

This Commit:
 - Runs the email code fetch in parallel with another request to use
   whichever we get back first, speeding up tests
@nshirley nshirley requested a review from a team as a code owner September 30, 2025 17:00
@nshirley nshirley merged commit 49bf7da into main Sep 30, 2025
19 checks passed
@nshirley nshirley deleted the chore/functional-test-account-cleaup-speed branch September 30, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants