Skip to content

fix(next): do not crash sub manage on canceled sub #19503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaberindeZA merged 1 commit into from
Sep 24, 2025
Merged

fix(next): do not crash sub manage on canceled sub #19503

StaberindeZA merged 1 commit into from
Sep 24, 2025

Conversation

@StaberindeZA
Copy link
Contributor

@StaberindeZA StaberindeZA commented Sep 24, 2025

Because

  • Retrieving upcoming invoices using customer and subscription fails for customers with a subscription set to cancel at period end.

This pull request

  • Updates query fetching an upcoming invoice to always behave as if the subscription is not set to cancel at period end.

Issue that this pull request solves

Closes: #PAY-3290

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

image image image

@StaberindeZA
fix(next): do not crash sub manage on canceled sub
970bfd9 
Because:

- Retrieving upcoming invoices using customer and subscription fails for
  customers with a subscription set to cancel at period end.

This commit:

- Updates query fetching an upcoming invoice to always behave as if the
  subscription is not set to cancel at period end.

Closes #PAY-3290
@StaberindeZA StaberindeZA requested a review from a team as a code owner September 24, 2025 18:06
@StaberindeZA StaberindeZA merged commit af6ef24 into main Sep 24, 2025
19 checks passed
@StaberindeZA StaberindeZA deleted the pay-3290-sub-cancel-error branch September 24, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xlisachan xlisachan xlisachan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StaberindeZA @xlisachan