-
Notifications
You must be signed in to change notification settings - Fork 217
feat(payments-next):Redirect old Subscription Management page to new page #19480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payments-next):Redirect old Subscription Management page to new page #19480
Conversation
6228005 to
c1c683a
Compare
0112be7 to
b66d18f
Compare
StaberindeZA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get the content-server redirect to work, please see inline comment, but otherwise this looks good.
packages/fxa-content-server/app/scripts/views/subscriptions_management_redirect.js
Outdated
Show resolved
Hide resolved
b66d18f to
51ba4b1
Compare
LZoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to see if someone else on FxA has bandwidth to test this locally real quick!
packages/fxa-content-server/server/lib/routes/react-app/route-definition-index.js
Outdated
Show resolved
Hide resolved
packages/fxa-content-server/server/lib/routes/react-app/route-definition-index.js
Outdated
Show resolved
Hide resolved
51ba4b1 to
441f1c6
Compare
packages/fxa-content-server/app/tests/spec/views/subscriptions_management_redirect.js
Outdated
Show resolved
Hide resolved
441f1c6 to
4229dc3
Compare
…page Because: * This commit: * Closes #
4229dc3 to
9fa85a7
Compare
| format: Boolean, | ||
| }, | ||
| usePaymentsNextSubscriptionManagement : { | ||
| default: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I change this to false? Or leave it as true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving it as true should be fine, now that New Sub Manage is live and stable in Prod.
StaberindeZA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the changes.
| format: Boolean, | ||
| }, | ||
| usePaymentsNextSubscriptionManagement : { | ||
| default: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving it as true should be fine, now that New Sub Manage is live and stable in Prod.
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3271
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
redir-new-sub-manage.mov
Other information (Optional)
Any other information that is important to this pull request.