Skip to content

Conversation

@elizabeth-ilina
Copy link
Contributor

@elizabeth-ilina elizabeth-ilina commented Sep 18, 2025

Because

  • In case there are links to the old Subscription Management page, redirect them to the new page.

This pull request

  • Uses the paymentsNextSubscriptionManagement to determine whether to redirect users to new Sub Manage page or not.

Issue that this pull request solves

Closes: #PAY-3271

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

redir-new-sub-manage.mov

Other information (Optional)

Any other information that is important to this pull request.

@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3271-redirect-old-subscription-management-page-to-new branch 11 times, most recently from 6228005 to c1c683a Compare September 19, 2025 19:31
@elizabeth-ilina elizabeth-ilina changed the title feat(payments-next):Redirect old Subscription Management page to new … feat(payments-next):Redirect old Subscription Management page to new page Sep 19, 2025
@elizabeth-ilina elizabeth-ilina marked this pull request as ready for review September 19, 2025 19:35
@elizabeth-ilina elizabeth-ilina requested a review from a team as a code owner September 19, 2025 19:35
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3271-redirect-old-subscription-management-page-to-new branch 2 times, most recently from 0112be7 to b66d18f Compare September 22, 2025 15:57
Copy link
Contributor

@StaberindeZA StaberindeZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get the content-server redirect to work, please see inline comment, but otherwise this looks good.

@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3271-redirect-old-subscription-management-page-to-new branch from b66d18f to 51ba4b1 Compare September 23, 2025 20:24
Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to see if someone else on FxA has bandwidth to test this locally real quick!

@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3271-redirect-old-subscription-management-page-to-new branch from 51ba4b1 to 441f1c6 Compare September 24, 2025 16:57
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3271-redirect-old-subscription-management-page-to-new branch from 441f1c6 to 4229dc3 Compare September 25, 2025 13:33
@elizabeth-ilina elizabeth-ilina force-pushed the PAY-3271-redirect-old-subscription-management-page-to-new branch from 4229dc3 to 9fa85a7 Compare September 29, 2025 20:47
format: Boolean,
},
usePaymentsNextSubscriptionManagement : {
default: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change this to false? Or leave it as true?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it as true should be fine, now that New Sub Manage is live and stable in Prod.

Copy link
Contributor

@StaberindeZA StaberindeZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the changes.

format: Boolean,
},
usePaymentsNextSubscriptionManagement : {
default: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it as true should be fine, now that New Sub Manage is live and stable in Prod.

@StaberindeZA StaberindeZA merged commit a9ac27c into main Sep 30, 2025
20 checks passed
@StaberindeZA StaberindeZA deleted the PAY-3271-redirect-old-subscription-management-page-to-new branch September 30, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants