Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Sep 16, 2025

Because

  • We want to protect this action with MFA

This pull request

  • Wraps the PageRecoveryPhoneRemove component with an MfaGuard

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner September 16, 2025 23:28
@dschom dschom force-pushed the FXA-12234 branch 3 times, most recently from 7fdebc0 to aff0e11 Compare September 17, 2025 20:41
@dschom dschom marked this pull request as draft September 17, 2025 21:43
@dschom dschom force-pushed the FXA-12234 branch 3 times, most recently from 063973c to a949738 Compare September 17, 2025 23:44
Copy link
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a first pass on this commit (looks like an additional commit may have been pulled in accidentally): e0d704c

@dschom
Copy link
Contributor Author

dschom commented Sep 18, 2025

Did a first pass on this commit (looks like an additional commit may have been pulled in accidentally): e0d704c

Thanks for looking, my branches are stacked to avoid merge conflicts. There's some other PRs that are not in draft that are ready for review.

@dschom dschom marked this pull request as ready for review September 23, 2025 22:38
@dschom dschom force-pushed the FXA-12234 branch 6 times, most recently from 046ce6f to e6da113 Compare September 25, 2025 20:35
@dschom
Copy link
Contributor Author

dschom commented Sep 25, 2025

Did a first pass on this commit (looks like an additional commit may have been pulled in accidentally): e0d704c

Thanks for pointing that out. I've dropped that commit and am retesting.

Because:
- We want to protect this action with MFA

This Commit:
- Wraps the PageRecoveryPhoneRemove component with an MfaGuard
Copy link
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to test this out locally, but Tested locally and looks good to me!

@dschom dschom merged commit bbbcd6b into main Sep 26, 2025
19 checks passed
@dschom dschom deleted the FXA-12234 branch September 26, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants