-
Notifications
You must be signed in to change notification settings - Fork 217
task(settings): Add MFA guard to remove 2FA SMS backup #19458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7fdebc0 to
aff0e11
Compare
063973c to
a949738
Compare
vpomerleau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first pass on this commit (looks like an additional commit may have been pulled in accidentally): e0d704c
Thanks for looking, my branches are stacked to avoid merge conflicts. There's some other PRs that are not in draft that are ready for review. |
046ce6f to
e6da113
Compare
Thanks for pointing that out. I've dropped that commit and am retesting. |
Because: - We want to protect this action with MFA This Commit: - Wraps the PageRecoveryPhoneRemove component with an MfaGuard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to test this out locally, but Tested locally and looks good to me!
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.