fix(prompt): Support prompt=none with 2FA, don't send two authorization reqs #18985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
reviewed
Jun 6, 2025
| if (!isEmail(email)) { | ||
| throw AuthUiErrors.EMAIL_REQUIRED; | ||
| } | ||
| console.log("Processing email submission:", email); |
chenba
reviewed
Jun 6, 2025
| return; | ||
| } | ||
|
|
||
| if (promptNoneCallCount.current > 0) { |
Contributor
There was a problem hiding this comment.
Do we know why it's being called twice?
Contributor
Author
There was a problem hiding this comment.
It wasn't clear to me why it was being called twice, I suspect something was changing in the dependenices but couldn't narrow it down.
chenba
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
promptNoneHandlertwiceIssue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-11847
Closes: https://mozilla-hub.atlassian.net/browse/FXA-11804
Checklist
Other information (Optional)
To test, enabled 2FA on your account and go through the prompt=none flow in 123Done.