Skip to content

Conversation

@StaberindeZA
Copy link
Contributor

@StaberindeZA StaberindeZA commented Jun 3, 2025

Because

  • In an attempt to have statsd for all 3rd party dependencies, add statsd recording to Auth.js actions and events.
  • On auth error, users are navigated to Auth.js default error page

This pull request

  • Add statsd counters signin, signout, prompt_none_fail and error
  • Add custom Auth.js error page

Issue that this pull request solves

Closes: #FXA-11670 #FXA-11754

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

To get to this Error Page follow these steps

  1. Navigate to Checkout, enter email and hit "Sign in"
  2. When on the FxA page, copy the URL
  3. Complete the FxA Sign In, and navigate back to Checkout successfully
  4. Open the copied URL into a new tab. This should load the FxA sign in page. Complete Sign In again
  5. The new error page should be shown

image

@StaberindeZA StaberindeZA requested review from a team as code owners June 3, 2025 20:18
@StaberindeZA StaberindeZA force-pushed the fxa-11670-add-statsd-to-authjs branch from 45f2db0 to 99ca66b Compare June 3, 2025 20:33
@@ -0,0 +1,4 @@
## Authentication Error page
auth-error-page-title = Sign in Error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## Group level comment
[empty newline]
string-1 = Foo
# Individual comment
string-2 = Bar

Sauce: #18932 (comment)

@StaberindeZA StaberindeZA force-pushed the fxa-11670-add-statsd-to-authjs branch from 99ca66b to 7f7e160 Compare June 3, 2025 22:13
Because:

- In an attempt to have statsd for all 3rd party dependencies, add
  statsd recording to Auth.js actions and events.
- On auth error, users are navigated to Auth.js default error page

This commit:

- Add statsd counters signin, signout, prompt_none_fail and error
- Add custom Auth.js error page

Closes #FXA-11670 #FXA-11754
@StaberindeZA StaberindeZA force-pushed the fxa-11670-add-statsd-to-authjs branch from 7f7e160 to 4bc524e Compare June 4, 2025 15:56
@StaberindeZA StaberindeZA merged commit 3e929ef into main Jun 5, 2025
19 checks passed
@StaberindeZA StaberindeZA deleted the fxa-11670-add-statsd-to-authjs branch June 5, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants