feat(settings): new FlowSetup2faBackupCodeConfirm component #18964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcolsson
approved these changes
Jun 3, 2025
vpomerleau
reviewed
Jun 3, 2025
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Thanks for your work here! Component looks good, but I suggested some changes for standardizing components.
packages/fxa-settings/src/components/Settings/FlowSetup2faBackupCodeConfirm/index.test.tsx
Show resolved
Hide resolved
| id="flow-setup-2fa-backup-code-confirm-code-input" | ||
| attrs={{ label: true }} | ||
| > | ||
| <InputText |
Contributor
There was a problem hiding this comment.
Recommend using FormVerifyTotp (our newest code verification component) for the input + button to standardize with other code verification.
Also, errors on submission should be displayed in Banner component.
Figma example of error handling: https://www.figma.com/design/Xnjs0YApSnC0CV6Ns5gCt4/2SV_Security_key_flow-Email_phone_number_2023?node-id=4990-9361&t=eCyhyMtgmd99z7sT-4
MagentaManifold
force-pushed
the
FXA-11625
branch
from
73e5eaa to
ea72e55
Compare
vpomerleau
requested changes
Jun 4, 2025
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
A few small nits - once these are fixed I'll be happy to ✅
packages/fxa-settings/src/components/Settings/FlowSetup2faBackupCodeConfirm/en.ftl
Outdated
Show resolved
Hide resolved
packages/fxa-settings/src/components/Settings/FlowSetup2faBackupCodeConfirm/index.tsx
Outdated
Show resolved
Hide resolved
packages/fxa-settings/src/components/Settings/FlowSetup2faBackupCodeConfirm/index.tsx
Outdated
Show resolved
Hide resolved
Because: * The design for 2FA setup has been updated * We want the UI component to be reusable * We want to document the component and states in storybook This commit: * Creates a new UI component with l10n, storybook and unit tests * Updates FormVerifyTotp to allow custom styling * Does not hook up the component in the setup flow - that will be done in a later ticket Closes #FXA-11625
MagentaManifold
force-pushed
the
FXA-11625
branch
from
ea72e55 to
75cac36
Compare
vpomerleau
approved these changes
Jun 5, 2025
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Thank you for the updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11625
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Other information (Optional)
Any other information that is important to this pull request.