fix(payments-paypal): Customer cannot purchase another product with their saved PayPal account #18956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const paypalCustomer = | ||
| await this.paypalCustomerManager.fetchPaypalCustomersByUid(uid); | ||
| const firstRecord = paypalCustomer.at(0); | ||
| const activeRecords: ResultPaypalCustomer[] = []; |
Contributor
There was a problem hiding this comment.
this feels like a good place for filtering the original list const activeRecords = paypalCustomer.filter(customer => record.status === 'active')
david1alvarez
approved these changes
Jun 3, 2025
Contributor
david1alvarez
left a comment
david1alvarez
left a comment
There was a problem hiding this comment.
r+wc, non-blocking
…heir saved PayPal account Because - PaypalCustomerMultipleRecordsError was being thrown if there were multiple records when it should only throw if there are multiple active records This pull request - returns the billing agreement ID of the active record and throws when there are multiple active records Closes: FXA-11772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-11772
Checklist
Put an
xin the boxes that apply