fix(payments-next):Applied coupon code before sign-in does not remain on checkout page after signing in #18943
+62
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
2 times, most recently
from
fc4cc90 to
cb3141a
Compare
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
3 times, most recently
from
53d1202 to
a08aa98
Compare
david1alvarez
approved these changes
Jun 2, 2025
julianpoy
reviewed
Jun 2, 2025
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
2 times, most recently
from
cc25bc3 to
c295ff7
Compare
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
3 times, most recently
from
1fd28b3 to
c9672c3
Compare
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
2 times, most recently
from
e7309cd to
dc63509
Compare
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
2 times, most recently
from
78f270a to
226e88d
Compare
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
4 times, most recently
from
177b99e to
c36ad41
Compare
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
from
c36ad41 to
a65e325
Compare
StaberindeZA
approved these changes
Jun 5, 2025
Contributor
StaberindeZA
left a comment
StaberindeZA
left a comment
There was a problem hiding this comment.
r+wc. Just a few small changes, but this looks good to me.
| fxaUid | ||
| let cart: ResultCart; | ||
|
|
||
| if (searchParams.cartId && fxaUid) { |
Contributor
There was a problem hiding this comment.
nit. should this include cartVersion as well?
apps/payments/next/app/[locale]/[offeringId]/[interval]/checkout/[cartId]/start/page.tsx
Show resolved
Hide resolved
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
2 times, most recently
from
9f95074 to
971e855
Compare
julianpoy
reviewed
Jun 5, 2025
Comment on lines
145
to
146
| redirectToUrl.searchParams.delete('countryCode'); | ||
| redirectToUrl.searchParams.delete('postalCode'); |
Member
There was a problem hiding this comment.
Can these be removed now, or do they need to remain here?
julianpoy
approved these changes
Jun 5, 2025
… on checkout page after signing in Because: * Before signing in, a valid coupon was applied to the subscription. However, after signing in, the coupon is no longer on the subscription. This commit: * Closes #FXA-11344
elizabeth-ilina
force-pushed
the
FXA-11344-applied-coupon-code-disappears
branch
from
971e855 to
03452c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-11344
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.