Skip to content

task(auth,graphql): Configure separate redis instance for rate limiting #18938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

dschom
Copy link
Contributor

@dschom dschom commented May 28, 2025

Because

  • We wanted to have a clean slate for rate limiting db state
  • We've stood up a separate instance in staging

This pull request

  • Adds config for a 'ratelimit' Redis instance

Issue that this pull request solves

Closes: (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Initially it seemed like we could just use the the custom's server redis instance, but ultimately decided it would be better to keep these DBs separate. There's a couple reasons for this:

  • Easier to roll back
  • Ensures no impact to existing customs service
  • Allows us to scale individually
  • Don't have to worry about old keys sticking around after fully migrating to new customs approach

Because:
- We wanted to have a clean slate for rate limiting db state

This Commit:
- Adds config for a 'ratelimit' redis instance
@dschom dschom marked this pull request as ready for review May 29, 2025 01:12
@dschom dschom requested a review from a team as a code owner May 29, 2025 01:12
@dschom dschom merged commit fa20324 into main May 29, 2025
19 checks passed
@dschom dschom deleted the create-seperate-redis-config-for-ratelimit branch May 29, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants