fix(perf): change css link tag's initial rel attr to preload #18933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - we don't want the CSS request to block rendering This commit: - change the link tag's initial rel to preload and switch to stylesheet on page load
vbudhram
reviewed
Jun 2, 2025
| filename: 'static/css/[name].[contenthash:8].css', | ||
| chunkFilename: 'static/css/[name].[contenthash:8].chunk.css', | ||
| }), | ||
| isEnvProduction && |
Contributor
There was a problem hiding this comment.
Should we do this all the time and not just prod?
Contributor
Author
There was a problem hiding this comment.
I could remove that but it wouldn't have an effect since that tag isn't injected and the css file isn't built for the dev env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit: