Skip to content

Conversation

@toufali
Copy link
Member

@toufali toufali commented May 27, 2025

Because

  • Yarn resolutions should be used as last resort
  • It doesn't look like this particular resolution does anything

This pull request

  • removes tap/typescript resolution

Issue that this pull request solves

Closes: FXA-11764

Other information (Optional)

A search for tap/typescript in our repo comes up empty and running yarn why tap/typescript results in error. After removing the resolution and running yarn install, the lockfile does not appear changed, suggesting this resolution is obsolete.

@toufali toufali marked this pull request as ready for review May 28, 2025 00:25
@toufali toufali requested a review from a team as a code owner May 28, 2025 00:25
Copy link
Contributor

@vpomerleau vpomerleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@toufali toufali merged commit 3246a71 into main May 28, 2025
19 checks passed
@toufali toufali deleted the remove-tap-typescript branch May 28, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants