fix(auth): Correctly store MetricsContext in third party auth component #18911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
reviewed
May 22, 2025
| const onClick = useCallback(async () => { | ||
| logViewEventOnce(`flow.${party}`, 'oauth-start'); | ||
|
|
||
| console.log("`${party}-${viewName}`", `${party}-${viewName}`); |
chenba
reviewed
May 22, 2025
| const modifiedParams = deleteParams(params, [ | ||
|
|
||
| // Combine flowQueryParams and paramsObject, ensuring all values are strings | ||
| const paramsObject = Object.fromEntries(params.entries()); |
Contributor
There was a problem hiding this comment.
Interesting. Is there something special to copying an object this way? (Instead of, say, const clone = {...og}.)
chenba
approved these changes
May 22, 2025
Contributor
chenba
left a comment
chenba
left a comment
There was a problem hiding this comment.
The approach make sense to me. There's a stray console log that probably should be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-11732
Checklist
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
This seemed like it was workign before because I was going through 123Done which manually copies flowIds in the query params.