chore(perf): load LegalWithMarkdown lazily #18908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpomerleau
approved these changes
May 22, 2025
Contributor
vpomerleau
left a comment
vpomerleau
left a comment
There was a problem hiding this comment.
Let's try it! I've tested locally and seeing the legal pages loading as expected 👍
| renderWithLocalizationProvider(<LegalPrivacy />); | ||
| testAllL10n(screen, bundle); | ||
| await waitFor(() => { | ||
| testAllL10n(screen, bundle); |
Contributor
There was a problem hiding this comment.
Just a word of caution - I've ocasionally seen false positives with grouped assertions in a waitFor block and/or non-explicit assertions (vs using expect(...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the gzip'd main js bundle by a little over 87 kB (from ~462 kB to ~374 kB), using commit 5e3506e as the baseline.