Skip to content

fix(payments): clear previous access token on signin #18907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
StaberindeZA merged 1 commit into from
May 27, 2025
Merged

fix(payments): clear previous access token on signin #18907

StaberindeZA merged 1 commit into from
May 27, 2025
+7 −3

Conversation

@StaberindeZA
Copy link
Contributor

@StaberindeZA StaberindeZA commented May 22, 2025

Because

  • Payments server reads potentially stale access token from previous session instead of using new access token from current session.

This pull request

  • Clears access token from localStorage when signing in from payments server checkout page.

Issue that this pull request solves

Closes: #FXA-11638

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@StaberindeZA
fix(payments): clear previous access token on signin
e3f61b4 
Because:

- Payments server reads potentially stale access token from previous
  session instead of using new access token from current session.

This commit:

- Clears access token from localStorage when signing in from payments
  server checkout page.

Closes #FXA-11638
@StaberindeZA StaberindeZA requested a review from a team as a code owner May 22, 2025 13:08
xlisachan
xlisachan approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@xlisachan xlisachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ thanks Reino!

@StaberindeZA StaberindeZA merged commit 44a2de2 into main May 27, 2025
19 checks passed
@StaberindeZA StaberindeZA deleted the fxa-11638-fix-auth-token-sp2 branch May 27, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xlisachan xlisachan xlisachan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StaberindeZA @xlisachan