Skip to content

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented May 22, 2025

Because

  • We are optimizing our bundle size

This pull request

  • Adds sentry plugin to tree sentry module from webpack

Issue that this pull request solves

Closes: FXA-9647

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Before:
image

After:
image

Other information (Optional)

To run this yourself, run BUILD_TARGETS=prod yarn workspace fxa-settings build-react-prod.

Looking at the webpack analyzer results are interesting too. You'll find them in packages/fxa-settings/build/prod

Also if you set the SENTRY_SOURCE_MAP_AUTH_TOKEN this plugin will supposedly upload better source maps to sentry and potentially give us better errors. TBD if this actually works. A token can be created here: https://sentry.io/orgredirect/organizations/mozilla/settings/auth-tokens/

@dschom dschom marked this pull request as ready for review May 22, 2025 01:17
@dschom dschom requested a review from a team as a code owner May 22, 2025 01:17
@dschom dschom force-pushed the optimize-sentry-bundle branch from 9401c6b to 31602d7 Compare May 22, 2025 01:18
@chenba
Copy link
Contributor

chenba commented May 22, 2025

Dan is on PTO so I'm going to merge this.

@chenba chenba merged commit 5e3506e into main May 22, 2025
19 checks passed
@chenba chenba deleted the optimize-sentry-bundle branch May 22, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants