Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(auth): Token pruner wouldn't accept --wait arg #15344

Merged
merged 1 commit into from
May 22, 2023
Merged

bug(auth): Token pruner wouldn't accept --wait arg #15344

merged 1 commit into from
May 22, 2023

Conversation

dschom
Copy link
Contributor

@dschom dschom commented May 20, 2023

Because

  • --wait=100 not having an effect

This pull request

  • Specifies that --wait is a number which fixes the problem

Issue that this pull request solves

Closes: # (issue number)

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@dschom dschom requested a review from a team as a code owner May 20, 2023 00:45
@dschom
bug(auth): Token pruner wouldn't accept --wait arg
6104616 
Because:
- --wait not having an effect

This Commit:
- Specifies that --wait is a number which fixes the problem
@dschom dschom force-pushed the fix-wait-arg-in-token-pruner branch from cae9f78 to 6104616 Compare May 22, 2023 16:58
@dschom dschom merged commit b2a4254 into main May 22, 2023
@dschom dschom deleted the fix-wait-arg-in-token-pruner branch May 22, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenba chenba chenba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dschom @chenba