This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
chore(deploy): upgrade to node 10 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That didn't come out right. I meant that with nothing else in the release, it might be a good juncture to upgrade the node version. |
|
Actually, scratch that, let's aim for 132 so we can run node 10 in local dev for a couple of weeks first. |
philbooth
force-pushed
the
pb/node-10
branch
from
1a9b215 to
db987c3
Compare
ghost
removed
| @@ -1,8 +1,6 @@ | |||
| language: node_js | |||
|
|
|||
| node_js: | |||
There was a problem hiding this comment.
This is the difference between what you and I did, I kept node 8 here and it blew up.
There was a problem hiding this comment.
It worked when that was still in there too fwiw, I only took it out after @vladikoff mentioned something in the auth server PR.
I thought maybe you forgot to update shrinkwrap and that overrode the optional dependencies or something?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #476.
Updates the dockerfile and circle to use node 10 images. Also updates nyc because of the handlebars nsp advisory. Didn't get any problems updating, so not sure what I did differently to @shane-tomlinson after he mentioned something in the meeting yesterday.
I figured we could try this for train 131? Otherwise there's nothing in master that merits tagging a new release.
@mozilla/fxa-devs r?