-
Notifications
You must be signed in to change notification settings - Fork 218
style(nimbus): wording changes to error card on new results page #14486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-new-fragment.html
Outdated
Show resolved
Hide resolved
|
oh we also talked about showing the date in better user friendly way |
Oh yea good catch Yashika -- I think we said it should just be another field like the error type, message, etc. |
experimenter/experimenter/nimbus_ui/templates/nimbus_experiments/results-new-fragment.html
Outdated
Show resolved
Hide resolved
|
Preview environment has been deployed. Preview URL: https://pr14486-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
4 similar comments
|
Preview environment has been deployed. Preview URL: https://pr14486-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr14486-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr14486-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
|
Preview environment has been deployed. Preview URL: https://pr14486-experimenter.preview.mozilla.cloud It may take up to 5 minutes for the environment to become available. You can monitor deployment status in Argo CD. |
yashikakhurana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Your experiment is complete, but there were issues computing some results. Contact Experimenter support using the button below for help resolving analysis errors. | ||
| {% else %} | ||
| Your experiment is still running — some metrics aren't available yet. This usually affects early results but may indicate a configuration issue; see error details on the right or Contact Experimenter Support using the button below. | ||
| {% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move this to constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you have any suggestions for making the timestamp more readable? i'm not too sure what else can be done besides having it alongside the other error data



Because
This commit
Fixes #14476