Skip to content

Conversation

@moibra05
Copy link
Contributor

@moibra05 moibra05 commented Jan 27, 2026

Because

  • Error cards on new results page required minor ui updates

This commit

  • Adds a new error message for experiments that have already completed
  • Changes made to "View Details" modal on errors
    • Adds a static modal title
    • Removes the second close button
    • Increase size of date

Fixes #14476

@moibra05
Copy link
Contributor Author

image image

@yashikakhurana
Copy link
Contributor

oh we also talked about showing the date in better user friendly way

@mikewilli
Copy link
Contributor

oh we also talked about showing the date in better user friendly way

Oh yea good catch Yashika -- I think we said it should just be another field like the error type, message, etc.

@mozcloud-preview-environments

Preview environment has been deployed.

Preview URL: https://pr14486-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

4 similar comments
@mozcloud-preview-environments

Preview environment has been deployed.

Preview URL: https://pr14486-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments

Preview environment has been deployed.

Preview URL: https://pr14486-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments

Preview environment has been deployed.

Preview URL: https://pr14486-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

@mozcloud-preview-environments

Preview environment has been deployed.

Preview URL: https://pr14486-experimenter.preview.mozilla.cloud

It may take up to 5 minutes for the environment to become available.
If the link doesn't work immediately, please wait a few moments and try again.

You can monitor deployment status in Argo CD.

Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the timestamp more readable

Image

Comment on lines +12 to +15
Your experiment is complete, but there were issues computing some results. Contact Experimenter support using the button below for help resolving analysis errors.
{% else %}
Your experiment is still running — some metrics aren't available yet. This usually affects early results but may indicate a configuration issue; see error details on the right or Contact Experimenter Support using the button below.
{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to constants?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you have any suggestions for making the timestamp more readable? i'm not too sure what else can be done besides having it alongside the other error data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-preview preview Create Preview Environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update experiment error card

4 participants