Add mitm, portal and connectivity endpoints #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@fiji-flo I think we also want a PR against https://github.com/mozilla/enterprise-repack/tree/master/enterfox. I'd like us to remove those from in-tree, but we may need to keep them for local builds to work without too much pain. |
Contributor
Author
|
Sure. I wasn't sure what's our strategy there. |
Contributor
Author
Contributor
|
@fiji-flo After today's meeting, should we do this? |
Contributor
|
After discussion with the release/updater teams, we want to repack as little information as possible because it's problematic to change later. This means we only want to repack the console URL. The endpoints that are required for networking, so the ones that we need before console comms are fully established, hence have to be derivable from the console address. The console then sets the remaining ones via prefs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repack is already merged mozilla/enterprise-repack#3