This repository was archived by the owner on Feb 11, 2020. It is now read-only.
Remove a-b test for homepage image #2104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also potentially fix IE11
mmmavis
reviewed
Nov 6, 2018
Member
mmmavis
left a comment
mmmavis
left a comment
There was a problem hiding this comment.
Changes in src/pages/about.js look good. I'm not sure what TrafficCop is about so I can't review assets/js/ab-tests.js
cadecairos
approved these changes
Nov 6, 2018
|
Question here -- what are the traffic cop urls/parameters for the new test (ordering of donation amounts?)? Looking for that info so I can analyze results. Last time it was "?test=no-img", "?test=img-a" and "?test=img-b" ... |
Contributor
Author
|
My mistake, this didn't close that previous ticket completely- it only partially addressed it. I'll re-open it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2103
May fix IE11 donations (#2097)
I didn't remove the heart image because I'm not entirely sure it's not used elsewhere.