Fix #231: report percentage of 100% should always report #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates the RateLimited CSPMiddleware to remove both `report-uri` and `report-to` directives based on report percentage.
stevejalim
approved these changes
Jul 10, 2024
| include_report_uri = random.randint(0, 100) < report_percentage | ||
| if not include_report_uri: | ||
| replace["report-uri"] = None | ||
| remove_report = random.randint(0, 99) >= report_percentage |
There was a problem hiding this comment.
Maybe it's my brain but I find this way around harder to track in my head. Maybe worth a comment to clarify?
There was a problem hiding this comment.
Ha, that's interesting. I was trying to remove the if not include and simplify to if remove since the code block inside the conditional removes the reporting. But perhaps I'm overlooking something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the RateLimited CSPMiddleware to remove both
report-uriandreport-todirectives based on report percentage.