Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 2 & upgrade code style #4

Merged
merged 4 commits into from
Nov 8, 2021
Merged

Drop support for Python 2 & upgrade code style #4

merged 4 commits into from
Nov 8, 2021

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented Nov 1, 2021

This will require the next release to be a semver-major bump.

Code style was updated using pyupgrade.

@eemeli eemeli requested a review from mathjazz November 1, 2021 14:35
mathjazz
mathjazz approved these changes Nov 8, 2021
View reviewed changes
Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the patch myself, but changes look good.

Nice work!

-203 lines of code! 🥳

@eemeli eemeli merged commit 9ebfc37 into main Nov 8, 2021
@eemeli eemeli deleted the drop-python2 branch November 8, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathjazz mathjazz mathjazz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eemeli @mathjazz