Fix new linting issues

mozilla · Oct 21, 2024 · 0222527 · 0222527
1 parent 8424b31
commit 0222527
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 12 deletions.
diff --git a/addon/src/button.js b/addon/src/button.js
@@ -20,7 +20,7 @@ export async function getCoverage(revPromise, path) {
 
 function disableButton(button, text) {
   button.setAttribute("disabled", "disabled");
-  button.style["cursor"] = "not-allowed";
+  button.style.cursor = "not-allowed";
   button.title = text;
 }
 

diff --git a/addon/src/dxr-common.js b/addon/src/dxr-common.js
@@ -27,7 +27,7 @@ let lineNoMap = (function () {
 export async function applyOverlay(revPromise, path) {
   let result = await getCoverage(revPromise, path);
 
-  if (!result.hasOwnProperty("coverage")) {
+  if (!Object.prototype.hasOwnProperty.call(result, "coverage")) {
     throw new Error("No 'coverage' field");
   }
   for (var l in result.coverage) {
@@ -65,7 +65,7 @@ export function removeOverlay() {
 export function getPath() {
   const breadcrumbs = document.querySelector(".breadcrumbs");
   if (!breadcrumbs) {
-    return;
+    return null;
   }
 
   return breadcrumbs.lastElementChild.href.split("/mozilla-central/source/")[1];

diff --git a/addon/src/hgmo.js b/addon/src/hgmo.js
@@ -23,17 +23,17 @@ document.querySelectorAll("title").forEach((title) => {
 
 async function applyOverlay(revPromise, path) {
   let result = await getCoverage(revPromise, path);
-  if (!result.hasOwnProperty("coverage")) {
+  if (!Object.prototype.hasOwnProperty.call(result, "coverage")) {
     throw new Error("No 'coverage' field");
   }
-  const data = result["coverage"];
+  const data = result.coverage;
   document.querySelectorAll("[id^='l']").forEach((e) => {
     const m = e.id.match(linePattern);
     if (!m) {
       return;
     }
     const linenum = m[1];
-    if (data.hasOwnProperty(linenum)) {
+    if (Object.prototype.hasOwnProperty.call(data, linenum)) {
       e.style.backgroundColor = data[linenum] > 0 ? "greenyellow" : "tomato";
     }
   });

diff --git a/addon/src/socorro.js b/addon/src/socorro.js
@@ -31,7 +31,7 @@ document
     }
     const revision = m[1].slice(0, 12); // shorten the revision
     const info = {
-      line: line,
+      line,
       element: a.parentNode,
     };
     let finfo;
@@ -47,7 +47,7 @@ document
     }
   });
 
-if (Object.keys(fileinfo).length != 0) {
+if (Object.keys(fileinfo).length) {
   const spinnerDiv = document.createElement("div");
   spinnerDiv.classList.add(
     "gecko_coverage_loader",
@@ -71,18 +71,21 @@ if (Object.keys(fileinfo).length != 0) {
       }
       fetchCoverage(revision, filename)
         .then((data) => {
-          if (data !== null && !data.hasOwnProperty("error")) {
-            if (!data.hasOwnProperty("coverage")) {
+          if (
+            data !== null &&
+            !Object.prototype.hasOwnProperty.call(data, "error")
+          ) {
+            if (!Object.prototype.hasOwnProperty.call(data, "coverage")) {
               throw new Error("No 'data' field");
             }
-            const covData = data["coverage"];
+            const covData = data.coverage;
             for (const le of lineElements) {
               const line = le.line;
               if (line in covData) {
                 // line is covered or uncovered
                 le.element.parentNode.style.backgroundColor =
                   covData[line] == 0 ? "tomato" : "greenyellow";
-                const gitBuildChangeset = data["git_build_changeset"];
+                const gitBuildChangeset = data.git_build_changeset;
                 const codecovUrl = `https://codecov.io/gh/mozilla/gecko-dev/src/${gitBuildChangeset}/${filename}#L${line}`;
                 const a = linkToCodecov.cloneNode(true);
                 a.setAttribute("href", codecovUrl);