parser: force proc macro fallback #698
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporate dtolnay/proc-macro2#220 to fix the case where a binary which is built with `panic = "abort"` aborts when calling into cbindgen functionality. mozilla#569 Signed-off-by: Grant Elbert <elbe0046@gmail.com>
|
Does this have any performance implications? Can the |
Of course, good thinking - thanks for the quick turnaround too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate dtolnay/proc-macro2#220 to fix the case where a binary which is built with
panic = "abort"aborts when calling into cbindgen functionality.Addresses #569.
While there is a test included that covers both additions I haven't made any changes to documentation. If there is desire to have these changes land in some form I'd just be looking for guidance on what doc changes would be appropriate, if any, in addition to any feedback on the overall direction of this change. Thanks!