Skip to content

Conversation

@suhaibmujahid
Copy link
Member

Fixes #2754

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@suhaibmujahid suhaibmujahid requested a review from Copilot October 29, 2025 19:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors logging initialization to move the "Run rule" log message from __init__ to the run() method, while also improving type annotations and logging format consistency.

  • Moved logging statement from constructor to run() method for better timing
  • Added type annotation to logger_extra dictionary
  • Updated log formatting from .format() to string interpolation with %s

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
bugbot/init.py Added type annotation dict[str, str] to logger_extra and removed default None value
bugbot/bzcleaner.py Moved "Run rule" log statement from __init__ to run() method and switched from .format() to %s string interpolation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@suhaibmujahid suhaibmujahid merged commit a4b8fa7 into mozilla:master Oct 29, 2025
8 checks passed
@suhaibmujahid suhaibmujahid deleted the log-run-improve branch October 29, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing rule name in some logging entries

2 participants