Skip to content

Conversation

@Avedis777
Copy link

@Avedis777 Avedis777 commented Dec 23, 2017

Fixing a bug that was issued in Thimble: 2343. This was an unnecessary import statement as the fonts imported are not used

Fix mozilla/thimble.mozilla.org#2343

@humphd
Copy link

humphd commented Dec 23, 2017

$ git grep Inconsolata
src/extensions/default/bramble/stylesheets/consoleTheme.less:    font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed;
src/extensions/default/bramble/stylesheets/consoleTheme.less:    font-family: 'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed;
src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
src/extensions/extra/JavaScriptCodeHints-Browser/styles/brackets-js-hints.css:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, fixed;
src/extensions/extra/MDNDocs/MDNDocs.less:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
src/extensions/extra/MDNDocs/MDNDocs.less:        font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
src/extensions/extra/WebPlatformDocs/WebPlatformDocs.less:    font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
src/extensions/extra/WebPlatformDocs/WebPlatformDocs.less:        font-family: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", Courier, monospace, fixed;
src/styles/brackets_fonts.less:/* Bramble Font - https://www.google.com/fonts/specimen/Inconsolata */
src/styles/brackets_fonts.less:@import url(https://fonts.googleapis.com/css?family=Inconsolata);
src/styles/brackets_fonts.less:@sourceFontFamily: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", "Courier New", Courier, monospace, fixed;
src/styles/brackets_fonts.less:@sourceFontFamily-Medium: "Menlo Regular", Consolas, Inconsolata, "Vera Sans", "Lucida Console", "Courier New", Courier, monospace, fixed;
src/view/ViewCommandHandlers.js:    var DEFAULT_FONT_FAMILY = "'Menlo Regular', Consolas, Inconsolata, 'Vera Sans', 'Lucida Console', Courier, monospace, fixed";

I see a bunch of places where it's used.

@Avedis777
Copy link
Author

But in the file that I modified, it wasn't used. Is the file I modified affecting any other file listed in your grep?

@humphd
Copy link

humphd commented Dec 30, 2017

Correct, this file will affect other parts of the system that assume it to be loaded.

@gideonthomas gideonthomas requested a review from humphd January 3, 2018 02:04
Copy link

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comments, as this will mean we don't load the Inconsolata family, which is used elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants