Add makedrive sync logic in brackets #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can you move this up with the other sync stuff (e.g., at line 46) so that it all goes together?
|
Can you also update the commit that we're using for the makedrive repo in this commit too? |
There was a problem hiding this comment.
Revert this change please, so it doesn't mess up landing Yoav's stuff.
humphd
added a commit
that referenced
this pull request
Jul 10, 2014
Add makedrive sync logic in brackets
JordanTheriault
pushed a commit
to JordanTheriault/brackets
that referenced
this pull request
May 7, 2015
Added 'Take a Selfie...' hint which will call the camera widget, giving ...
Th30
added a commit
to Th30/brackets
that referenced
this pull request
Apr 10, 2017
feihaozi77
referenced
this pull request
in feihaozi77/brackets
Nov 19, 2017
gideonthomas
pushed a commit
that referenced
this pull request
Jan 9, 2018
Fix mozilla/thimble.mozilla.org#2506 * Added all components for Border Radius Inline editor * remove text selection after closing inline border radius editor * made allCornerSlider and individual slider work seperately without effecting each other * added the slider value indicator * modified BorderRadiusEditor to allow keeping all units(%,em,px) * modified BorderRadiusEditor to allow keeping all units(%,em,px)--#2 * added radio buttons to toggle slider unit * making individual corner values sync with allcorner mode value * Border UI updates * fixed when close inlineEditor the cursor do not go to top * Light theme + CSS cleanup * code cleaned up * fixed indentation and replaceAll() local function * fixed some indentations * removed _values local property from borderRadiusEditor.js * Fixed few indentations and comments * added comment for borderRadiusUtil * added more comments in borderRadiusUtils.js * Fixed few comments * Review fixes * Fixed some codes according to comments from gide * fixed indentation * fixed indentation 2x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.