Skip to content

Conversation

@Plumpernickel
Copy link

No description provided.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do this up here, make it a local variable in showSaveDialog

@humphd
Copy link

humphd commented Jul 10, 2014

Change this to:

+ function showSaveDialog(title, initialPath, defaultName, callback) {
+     var selectedPath;
+     var saveResponse = window.prompt(title, defaultName);
+     if(saveResponse){
+         initialPath = initialPath || '/';
+         selectedPath = initialPath + saveResponse;
+         callback(null, selectedPath);
+     } else {
+        // User hit cancel
+        callback();
+     }
+ }

@humphd
Copy link

humphd commented Jul 10, 2014

Change to 4-space indents please, to match the rest of the file. r=me with that fix.

humphd added a commit that referenced this pull request Jul 10, 2014
Added save as functionality to UI
@humphd humphd merged commit 354f400 into mozilla:browser-appshell Jul 10, 2014
humphd pushed a commit that referenced this pull request Aug 8, 2014
Theme Tweaks - There you go, this is more like it!
humphd pushed a commit that referenced this pull request May 17, 2015
humphd added a commit that referenced this pull request Feb 16, 2017
Don't run npm-install grunt task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants