This repository has been archived by the owner on Apr 16, 2019. It is now read-only.
pin event-stream to 3.3.5 #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groovecoder
force-pushed
the
pin-event-stream-to-3.3.5
branch
from
634378b
to
6edbe2d
Compare
pdehaan
reviewed
Nov 27, 2018
| @@ -40,5 +40,8 @@ | |||
| "start": "web-ext run --no-reload", | |||
| "test": "echo 'Error: no test specified' && exit 0", | |||
| "watch": "web-ext run" | |||
| }, | |||
| "dependencies": { | |||
| "event-stream": "3.3.4" | |||
There was a problem hiding this comment.
- Should this be in
devDependenciesalong w/ npm-run-all? - According to Issue with dependency on flatmap-stream via ps-tree mysticatea/npm-run-all#155, it looks like the issue was solved in npm-run-all@4.1.5 by "switching from ps-tree package to pidtree package for security reasons".
There was a problem hiding this comment.
Ah yeah, that fix will work here. I couldn't do that in blurts-server because it had nodemon which also used ps-tree. I'll change this one to npm-run-all@4.1.5
There was a problem hiding this comment.
It looks like nodemon was fixed in v1.18.7 release. I'll comment in the blurts-server repo in case we want to bump that version and remove our pinned version of event-stream.
|
Superseded by #139. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.