Skip to content

bug 1955428 - Use column replacement to place extended attribution and distribution info in client_info with the base info #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bug 1955428 - Use column replacement to place extended attribution and distribution info in client_info with the base info #7252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sql_generators/stable_views/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,12 @@ def write_view_if_not_exists(
f"metrics.{metrics_field['name']} AS {metrics_2_types_to_rename[metrics_field['name']]}"
]

# Extended attribution and distribution information should join the rest in client_info.
replacements += [
"metrics.object.glean_attribution_ext AS client_info.attribution.ext",
"metrics.object.glean_distribution_ext AS client_info.distribution.ext",
]

if datetime_replacements_clause or metrics_2_aliases or metrics_2_exclusions:
except_clause = ""
if metrics_2_exclusions:
Expand Down