Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission old VPN landing page template (Fixes #15226) #15243

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Oct 3, 2024

One-line summary

Removes old VPN landing page and pricing page templates.

Issue / Bugzilla link

15226

Testing

Things to verify:

  • Check I didn't remove any shared strings that are still in use.
  • Check i didn't remove any images that are still in use.
  • Check I didn't remove any SCSS/JS files that are still in use.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.42%. Comparing base (2a7caf9) to head (1d8694b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15243   +/-   ##
=======================================
  Coverage   78.41%   78.42%           
=======================================
  Files         162      162           
  Lines        8350     8344    -6     
=======================================
- Hits         6548     6544    -4     
+ Misses       1802     1800    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@four-keys-mozilla four-keys-mozilla bot temporarily deployed to test October 3, 2024 13:08 Inactive
@alexgibson
Copy link
Member Author

@alexgibson alexgibson marked this pull request as ready for review October 3, 2024 13:41
@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Oct 3, 2024
@craigcook craigcook self-assigned this Oct 3, 2024
Copy link
Member

@craigcook craigcook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but some suggestions for additional tidying if you're up for it. If you'd rather do those things separately this is good to merge (though should still remove the HELLO to play it safe). r+wc 🥔

bedrock/products/views.py Show resolved Hide resolved
@craigcook craigcook removed the Needs Review Awaiting code review label Oct 3, 2024
@alexgibson alexgibson force-pushed the remove-old-vpn-templates branch from d5b4dc4 to 1d8694b Compare October 7, 2024 08:03
@alexgibson alexgibson merged commit a333542 into mozilla:main Oct 7, 2024
4 checks passed
@alexgibson alexgibson deleted the remove-old-vpn-templates branch October 7, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants