Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc a11y fixes #15186

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Misc a11y fixes #15186

merged 1 commit into from
Sep 20, 2024

Conversation

alexgibson
Copy link
Member

One-line summary

Fixes a handful of small things the a11y checker turned up.

Significant changes and points to review

  • Adds role="contentinfo" to both old and new footer components.
  • Fixes heading levels in old footer.
  • Removes stray </div> from German /built-for-you/ page.
  • Adds <main> landmark to new /about/ page.

Issue / Bugzilla link

#15004

Testing

@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Sep 19, 2024
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:accessibility:

@reemhamz reemhamz merged commit 278e58f into mozilla:main Sep 20, 2024
5 checks passed
reemhamz pushed a commit that referenced this pull request Oct 10, 2024
@stephaniehobson stephaniehobson removed the Needs Review Awaiting code review label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Third level priority - Nice to have Review: µ Code review time: 5 minutes or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants