Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission old /leadership page template (Fixes #15135) #15183

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

alexgibson
Copy link
Member

@alexgibson alexgibson commented Sep 19, 2024

One-line summary

Removes old leadership page template

Issue / Bugzilla link

#15135

Testing

Remember to run make preflight to pull the latest dev DB.

@alexgibson alexgibson force-pushed the decomm-leadership branch 2 times, most recently from 7c1ee76 to 77065e1 Compare September 19, 2024 10:25
@alexgibson alexgibson added P3 Third level priority - Nice to have Needs Review Awaiting code review Review: XS Code review time: up to 30min labels Sep 19, 2024
@alexgibson alexgibson marked this pull request as ready for review September 19, 2024 10:26
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (2df9c9b) to head (d5af013).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15183   +/-   ##
=======================================
  Coverage   77.88%   77.88%           
=======================================
  Files         163      163           
  Lines        8480     8480           
=======================================
  Hits         6605     6605           
  Misses       1875     1875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@four-keys-mozilla four-keys-mozilla bot temporarily deployed to test September 19, 2024 10:42 Inactive
@alexgibson
Copy link
Member Author

Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is the only thing I see on the page. It doesn't seem to resolve to the new CMS leadership page and made sure to run a make preflight. Is this something else I might be missing?

Screenshot 2024-09-20 at 1 47 13 PM

@alexgibson
Copy link
Member Author

alexgibson commented Sep 20, 2024

@reemhamz the localhost page should match what's on https://www-dev.allizom.org/en-US/about/leadership/ (we only include enough data on www-dev to satisfy integration tests).

See https://bedrock.readthedocs.io/en/latest/cms.html#i-ve-downloaded-a-fresh-db-and-the-images-are-missing for downloading images locally.

Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving this a front-end stamp of approval. 💯 r+
I'll leave this for you to merge in case

@reemhamz reemhamz removed the Needs Review Awaiting code review label Sep 30, 2024
@alexgibson alexgibson merged commit 99dc133 into mozilla:main Oct 1, 2024
5 checks passed
@alexgibson alexgibson deleted the decomm-leadership branch October 1, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Third level priority - Nice to have Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants