-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decommission old /leadership page template (Fixes #15135) #15183
Conversation
7c1ee76
to
77065e1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15183 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 163 163
Lines 8480 8480
=======================================
Hits 6605 6605
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
Successful test run: https://github.com/mozilla/bedrock/actions/runs/10939389570 |
77065e1
to
f8553b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reemhamz the localhost page should match what's on https://www-dev.allizom.org/en-US/about/leadership/ (we only include enough data on www-dev to satisfy integration tests). See https://bedrock.readthedocs.io/en/latest/cms.html#i-ve-downloaded-a-fresh-db-and-the-images-are-missing for downloading images locally. |
d3953d1
to
d5af013
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving this a front-end stamp of approval. 💯 r+
I'll leave this for you to merge in case
One-line summary
Removes old leadership page template
Issue / Bugzilla link
#15135
Testing
Remember to run
make preflight
to pull the latest dev DB.