Split Leadership onto multiple pages with navigation [fix #11878] #12002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcook
added
P2
craigcook
commented
Aug 3, 2022
| // trigger modal on page load if hash is present and matches a person with a bio | ||
| if (window.location.hash) { | ||
| var target = document.getElementById(window.location.hash.substr(1)); |
There was a problem hiding this comment.
It seems this broke semi-recently because substr is deprecated. Likely still works in older browsers but doesn't work in current Nightly. I swiped the getHash function from /products/vpn/ and I'll work on another PR to fix a few more uses of hash.substr(1) elsewhere.
craigcook
force-pushed
the
11878-leadership
branch
from
70df385 to
41dcf83
Compare
craigcook
added
P1
|
Got a few new updates to add. Standby... |
nathan-barrett
approved these changes
Aug 10, 2022
Also add Skogen Lund
craigcook
force-pushed
the
11878-leadership
branch
from
41dcf83 to
215a241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Breaks leadership teams onto multiple pages with sidebar navigation instead of putting them all on a single page.
Issue / Bugzilla link
#11878
Testing
http://localhost:8000/about/leadership/
To test this work:
tests/functional/test_leadership.pymozorg.about.leadershiphave updated tomozorg.about.leadership.index