Skip to content

Commit

Permalink
Add a Pocket-specific brands.ftl file and wire it in
Browse files Browse the repository at this point in the history
The -brand-name-read-it-later-inc string is moved from l10n/en/brands.ftl
into the new Pocket-specific one, and can be used as proof that the new brands
file is being loaded, because the correct Read It Later, Inc string appears
at the bottom of the about page.

Also improve some of the brand-meets-product phrasing, to help with translation
- eg Pocket Premium, Pocket for Firefox
  • Loading branch information
stevejalim committed May 3, 2022
1 parent d442955 commit c283150
Show file tree
Hide file tree
Showing 5 changed files with 38 additions and 6 deletions.
7 changes: 5 additions & 2 deletions bedrock/settings/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,11 @@
"nav",
"footer",
]
FLUENT_POCKET_LOCAL_PATH = ROOT_PATH / "l10n-pocket"
FLUENT_PATHS.insert(0, FLUENT_POCKET_LOCAL_PATH)

# Swap the default FLUENT_LOCAL_PATH for a Pocket-specific one
FLUENT_PATHS.pop(FLUENT_PATHS.index(FLUENT_LOCAL_PATH))
FLUENT_LOCAL_PATH = ROOT_PATH / "l10n-pocket"
FLUENT_PATHS.insert(0, FLUENT_LOCAL_PATH)

else:
ROOT_URLCONF = "bedrock.urls.mozorg_mode"
Expand Down
30 changes: 30 additions & 0 deletions l10n-pocket/en/brands.ftl
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at https://mozilla.org/MPL/2.0/.

### Please read the trademarks localization guide
### https://mozilla-l10n.github.io/styleguides/mozilla_general/index.html#brands-copyright-and-trademark

## Company names

-brand-name-mozilla = Mozilla
-brand-name-pocket = Pocket
-brand-name-read-it-later-inc = Read It Later, Inc.
## Pocket product

-brand-name-pocket-premium = Pocket Premium
-brand-name-pocket-for-firefox = Pocket for Firefox
## Firefox browsers

-brand-name-firefox = Firefox
## Third parties

-brand-name-twitter = Twitter
-brand-name-facebook = Facebook
-brand-name-google-play = Google Play
-brand-name-apple-app-store = Apple App Store
4 changes: 2 additions & 2 deletions l10n-pocket/en/footer.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
pocket-footer-products = Products
pocket-footer-must-read-articles = Must-read articles
pocket-footer-daily-newsletter = Daily newsletter
pocket-footer-pocket-premium = { -brand-name-pocket } Premium
pocket-footer-pocket-premium = { -brand-name-pocket-premium }
pocket-footer-save-to-pocket-extensions = Save to { -brand-name-pocket } extensions
pocket-footer-company = Company
pocket-footer-about = About
Expand All @@ -22,7 +22,7 @@ pocket-footer-developer-api = Developer API
pocket-footer-pocket-for-publishers = { -brand-name-pocket } for publishers
pocket-footer-advertise = Advertise
pocket-footer-get-the-app = Get the app
pocket-footer-download-on-apple-app-store = Download On The { -brand-name-apple } { -brand-name--app-store }
pocket-footer-download-on-apple-app-store = Download On The { -brand-name-apple-app-store }
pocket-footer-get-it-google-play = Get It On { -brand-name-google-play }
# Variables:
# $mozorgabout (url) link to https://www.mozilla.org/about/
Expand Down
2 changes: 1 addition & 1 deletion l10n-pocket/en/pocket/about.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pocket-about-internet-filled-with-buried-treasures = The internet is filled with
# $pocket_and_firefox_attrs (string) - attrs for hyperlink
# $pocket_daily_newsletter_attrs (string) - attrs for hyperlink
# $pocket_app_attrs (string) - attrs for hyperlink
pocket-about-our-curators-vet-the-most-fascinating = Our curators vet the most fascinating finds to ensure they’re from a diverse range of publications with a track record of trustworthy and accurate coverage, and we share them on <a { $pocket_home_attrs }>{ $pocket_home_domain }</a>, <a {$pocket_and_firefox_attrs}>{ -brand-name-pocket } for { -brand-name-firefox }</a>, in our <a { $pocket_daily_newsletter_attrs }">daily newsletter</a>, and within the <a { $pocket_app_attrs }>{ -brand-name-pocket } app</a>. Our recommendations are available primarily in English and German, though we look forward to sharing in more languages in the future.
pocket-about-our-curators-vet-the-most-fascinating = Our curators vet the most fascinating finds to ensure they’re from a diverse range of publications with a track record of trustworthy and accurate coverage, and we share them on <a { $pocket_home_attrs }>{ $pocket_home_domain }</a>, <a {$pocket_and_firefox_attrs}>{ -brand-name-pocket-for-firefox }</a>, in our <a { $pocket_daily_newsletter_attrs }">daily newsletter</a>, and within the <a { $pocket_app_attrs }>{ -brand-name-pocket } app</a>. Our recommendations are available primarily in English and German, though we look forward to sharing in more languages in the future.
pocket-about-use-pocket-your-way = Use { -brand-name-pocket } your way
Expand Down
1 change: 0 additions & 1 deletion l10n/en/brands.ftl
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@
## Pocket

-brand-name-pocket = Pocket
-brand-name-read-it-later-inc = Read It Later, Inc.
## Mozilla projects

Expand Down

0 comments on commit c283150

Please sign in to comment.