Skip to content

Fix #92 - Expose authenticator details to calling application #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2020
Merged

Fix #92 - Expose authenticator details to calling application #93

merged 2 commits into from
Aug 10, 2020

Conversation

jcjones
Copy link
Contributor

@jcjones jcjones commented Jun 27, 2019 •
edited
Loading

This patch sets groundwork for additional authenticator metadata that Firefox will ultimately want to surface as part of its UX. Not all platforms have full support, but those that don't return safe values.

@jcjones
Copy link
Contributor Author

jcjones commented Jun 27, 2019

Sending YKPIV_INS_GET_VERSION (0xFD) as the "ins" field in an APDU with zeroes in cla, p1,p2, and the data buffer, via the U2F_MSG mechanism , is returning SW_INS_NOT_SUPPORTED (0x6d, 0x00).

I'm doing this after a U2F Register or U2F Authenticate call.

I take this to mean in order to use the "Get Version" query, I need to implement the smart card protocol, which would be a substantial expansion of the FIDO U2F implementation here far beyond the intention of this library. Hopefully there's another mechanism available, though I have not yet heard back from Yubico on that.

@jcjones
Copy link
Contributor Author

jcjones commented Jul 15, 2019

With the help of Yubico, I've made this work well on MacOS via already-readily-accessible (but unknown to me) structs.

I just need to verify this branch works on all four platforms and then I can make a release from it.

@jcjones jcjones force-pushed the 92-authenticator_details branch 2 times, most recently from d3cf83d to 9de1ac8 Compare July 16, 2019 16:01
@jcjones jcjones force-pushed the 92-authenticator_details branch from 9de1ac8 to e1f0662 Compare July 27, 2020 21:21
@jcjones jcjones changed the base branch from master to main July 27, 2020 21:23
@jcjones jcjones changed the title Fix #92 - Expose authenticator details to calling application [WIP] Fix #92 - Expose authenticator details to calling application Jul 27, 2020
@jcjones jcjones force-pushed the 92-authenticator_details branch from d660591 to 639c4ba Compare July 27, 2020 21:36
@jcjones jcjones mentioned this pull request Aug 4, 2020
Merged
@jcjones jcjones requested a review from kjacobs-moz August 4, 2020 16:33
@jcjones jcjones force-pushed the 92-authenticator_details branch 2 times, most recently from de5db92 to 7b3eb30 Compare August 6, 2020 20:47
@jcjones jcjones force-pushed the 92-authenticator_details branch from 7b3eb30 to 93282ba Compare August 6, 2020 21:33
kjacobs-moz
kjacobs-moz reviewed Aug 10, 2020
View reviewed changes
Copy link

@kjacobs-moz kjacobs-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment/question on the macOS implementation, otherwise this looks right.

@jcjones jcjones requested a review from kjacobs-moz August 10, 2020 20:36
kjacobs-moz
kjacobs-moz approved these changes Aug 10, 2020
View reviewed changes
Copy link

@kjacobs-moz kjacobs-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcjones jcjones merged commit c270f85 into main Aug 10, 2020
@jcjones jcjones deleted the 92-authenticator_details branch August 10, 2020 21:49
jcjones added a commit that referenced this pull request Sep 10, 2020
@jcjones
Tagging v0.3.0
38e640d 
Major changes:
* Move to Rust 2018 edition #125
* Remove dependency on boxfnonce #121
* Reworked error handling #130
* Added a higher-level AuthenticatorService that can use multiple backends #123
* Changed the C API to use the new AuthenticatorService #123
* Added a Status channel for backends #122
* Now obtaining HID report sizes from the descriptors #112
* Add authenticator USB and Firmware details to the C API #93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjacobs-moz kjacobs-moz kjacobs-moz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcjones @kjacobs-moz